Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vignette upkeep #494

Merged
merged 3 commits into from
Nov 25, 2024
Merged

vignette upkeep #494

merged 3 commits into from
Nov 25, 2024

Conversation

mrcaseb
Copy link
Member

@mrcaseb mrcaseb commented Nov 24, 2024

closes #492

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 24, 2024 •
edited
Loading

🚀 Deployed on https://67430cd9a649eb84cde9fc20--thirsty-brown-d38ddf.netlify.app

@mrcaseb mrcaseb marked this pull request as ready for review November 24, 2024 11:16
@mrcaseb mrcaseb requested a review from guga31bb November 24, 2024 11:16
guga31bb
guga31bb approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@guga31bb guga31bb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement, thank you!

@mrcaseb mrcaseb merged commit 429d5a3 into master Nov 25, 2024
6 of 7 checks passed
@mrcaseb mrcaseb deleted the vignette-updates branch November 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guga31bb guga31bb guga31bb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update vignettes/nflfastR.Rmd
2 participants
@mrcaseb @guga31bb