-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lateral_return_yards
variable?
#355
Comments
This is actually not a bug in return yards as it is exactly the same like for rushing or receiving yards when laterals happen in a play. We could catch this for plays with one lateral (!) by adding a lateral_return_yards variable for stat IDs 27 and 28 Here nflfastR/R/helper_tidy_play_stats.R Line 189 in 0fa754d
and here nflfastR/R/helper_tidy_play_stats.R Line 201 in 0fa754d
Analog to stat IDs 23 and 24 for example nflfastR/R/helper_tidy_play_stats.R Line 149 in 0fa754d
nflfastR/R/helper_tidy_play_stats.R Line 163 in 0fa754d
As soon as multiple laterals with non 0 yards happen in a play there is no chance to see them in either of these variables. That would be very inefficient in a tidy data structure. |
For |
We will not add a new variable to pbp but the new function |
**Have you installed the latest development version of the package(s) in question? **
Yes
Describe the bug
return_yards
is returning the wrong number in the pbp df.Reprex
Expected Behaviour
return_yards
should be 6. Anthony Harris should get 2, then he laterals to Darius Slay who gets 4 more. Butreturn_yards
shows 4, only counting the yards post-lateral.nflverse_sitrep()
sitrep
# nflverse_sitrep() goes here
The text was updated successfully, but these errors were encountered: