Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021_01_ARI_TEN has a extra_point issue #277

Closed
ak47twq opened this issue Sep 16, 2021 · 1 comment · Fixed by #298
Closed

2021_01_ARI_TEN has a extra_point issue #277

ak47twq opened this issue Sep 16, 2021 · 1 comment · Fixed by #298
Labels
bug Something isn't working

Comments

@ak47twq
Copy link

ak47twq commented Sep 16, 2021

seasonnum1 <- 2021
seasonnum2 <- 2021
weeknum1 <- 1
weeknum2 <- 1

extra_point<-pbp%>%
     filter(season>=seasonnum1, season<=seasonnum2, week>=weeknum1, week<=weeknum2, extra_point_attempt==1)%>% 	 
	 select(play_id, game_id,season, week, qtr, time, posteam, desc, play_type, extra_point_result, defensive_extra_point_conv,defensive_extra_point_attempt)%>%
	 collect()

play id:2003
desc:5-M.Prater extra point is GOOD, Center-46-A.Brewer, Holder-14-A.Lee. PENALTY on TEN-29-D.Cruikshank, Defensive Offside, 5 yards, enforced between downs.
play_type:no_play

i wonder if the play_type should be "extra_point"?

@guga31bb guga31bb added the bug Something isn't working label Sep 16, 2021
@guga31bb
Copy link
Member

Seems like a bug:

pbp <- nflfastR::build_nflfastR_pbp("2021_01_ARI_TEN")

pbp %>%
  filter(play_id == 2003) %>%
  select(play_id, game_id, posteam, desc, play_type, play_type_nfl, extra_point_result, extra_point_attempt)

# A tibble: 1 x 8
  play_id game_id   posteam desc                  play_type play_type_nfl extra_point_res~ extra_point_att~
    <dbl> <chr>     <chr>   <chr>                 <chr>     <chr>         <chr>                       <dbl>
1    2003 2021_01_~ ARI     5-M.Prater extra poi~ no_play   XP_KICK       good                            1

Probably needs to be fixed here https://github.com/nflverse/nflfastR/blob/master/R/helper_add_nflscrapr_mutations.R#L331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants