-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates react-fast-compare to get support for Preact #559
Updates react-fast-compare to get support for Preact #559
Conversation
It seems to be complaining about |
@esbenam I think so for now until we settle on a standard. |
In 3.1.1 react-fast-compare added support for preact's internal data structure when handling recursive objects so it now ignores those correctly. This means the maximum call stack size exceeded issue doesn't happen any longer.
48cde49
to
12d05ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 3 3
Lines 292 292
=======================================
Hits 283 283
Misses 9 9 Continue to review full report at Codecov.
|
@cwelch5 it seems that did the trick. I have signed the CLA, but the CLAAssistant doesn't seem to pick up on it. Do I have to do anything else? |
I can see you already have dependabot creating the same PR. Should I just close this on? |
Thanks @esbenam , but I'll look at yours over the bots 😂 - you deserve the credit. Let me give it a quick run through on my machine because it is a major upgrade of a core dependency. |
Released with 6.1.0. |
In 3.1.1 react-fast-compare added support for preact's internal data
structure when handling recursive objects so it now ignores those
correctly. This means the
maximum call stack size exceeded
issuedoesn't happen any longer.