Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the dca-template-config.json to this repo and use for testing #370

Closed
anngvu opened this issue Nov 29, 2023 · 0 comments · Fixed by #375
Closed

Add the dca-template-config.json to this repo and use for testing #370

anngvu opened this issue Nov 29, 2023 · 0 comments · Fixed by #375
Assignees

Comments

@anngvu
Copy link
Collaborator

anngvu commented Nov 29, 2023

Will likely bundle this with the next data model update, similarly to GF's PR here:

In this Slack announcement, D&T announced that we can maintain the templates config.json somewhere and DCA will reference the link (probably because keeping on top of PRs to update configs for 10+ DCCs is a lot of work):

For the next release of DCA in mid-December we are going to switch to new config files
...
the template dropdown config and logo will be referenced by a URL, not the filepath in data_curator_config. This means those files can live elsewhere, like your data model repo.
@anngvu anngvu self-assigned this Nov 29, 2023
@anngvu anngvu moved this to Todo in NF-OSI Sprints Dec 4, 2023
@anngvu anngvu moved this from Todo to In Progress in NF-OSI Sprints Dec 5, 2023
@anngvu anngvu linked a pull request Dec 6, 2023 that will close this issue
@anngvu anngvu closed this as completed Dec 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in NF-OSI Sprints Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant