Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add license check to linter #1295

Open
klkeys opened this issue Oct 19, 2021 · 2 comments
Open

add license check to linter #1295

klkeys opened this issue Oct 19, 2021 · 2 comments
Labels
command line tools Anything to do with the cli interfaces linting

Comments

@klkeys
Copy link

klkeys commented Oct 19, 2021

Is your feature request related to a problem? Please describe

as part of software best practices, it's probably wise (and sometimes maybe necessary) to include software licenses for packaged software. for nf-core/modules, this would mean enforcing or at least noting the software license in meta.yml

Describe the solution you'd like

  1. add code to the nf-core linter to check for a line in meta.yml such as license: ['MIT']
  2. ensure that nf-core modules create also generates this line when templating a new module

Describe alternatives you've considered

could opt for no-build option, if people are happy with status quo. for those in environments with high audit risk, this could yield a rather painful experience down the road..

Additional context

see parallel issue in nf-core/modules here

@klkeys klkeys added linting command line tools Anything to do with the cli interfaces labels Oct 19, 2021
@drpatelh
Copy link
Member

drpatelh commented Dec 8, 2021

Related to #1155

@ggabernet
Copy link
Member

nf-core lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command line tools Anything to do with the cli interfaces linting
Projects
None yet
Development

No branches or pull requests

3 participants