Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module: gatk4/addorreplacereadgroups #838

Closed
3 of 4 tasks
jfy133 opened this issue Oct 13, 2021 · 3 comments · Fixed by #5302
Closed
3 of 4 tasks

new module: gatk4/addorreplacereadgroups #838

jfy133 opened this issue Oct 13, 2021 · 3 comments · Fixed by #5302
Assignees
Labels
new module Adding a new module

Comments

@jfy133
Copy link
Member

jfy133 commented Oct 13, 2021

I think it would be good to have a module for gatk4/addorreplacereadgroups

  • This module does not exist yet with the nf-core modules list command
  • There is no open pull request for this module
  • There is no open issue for this module
  • If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module
@jfy133 jfy133 added the new module Adding a new module label Oct 13, 2021
@simeonhebrew simeonhebrew self-assigned this Oct 27, 2021
@ramprasadn
Copy link
Contributor

@jfy133 I don't know if there is consensus regarding subtools that are available in both picard and gatk, but the picard version of addorreplacereadgroups is already available in nf-core/modules. If you think that should be enough, I suppose we can close this issue. If not, we can make this a "good first issue" and save it for the upcoming hackathon. What do you think?

@maxulysse
Copy link
Member

I think we already have a couple of modules both in picard and in gatk.
From what I understand RNA people tend to use picard, and DNA folks tend to use GATK.

@jfy133
Copy link
Member Author

jfy133 commented Mar 8, 2023

yeah I agree, we would more likely use GATK4.

I think I may still need this at some point, so we can keep it open until next spring cleaning 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
No open projects
5 participants