Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subworkflow Standards #806

Closed
edmundmiller opened this issue Oct 8, 2021 · 2 comments
Closed

Subworkflow Standards #806

edmundmiller opened this issue Oct 8, 2021 · 2 comments
Labels
stale Stale

Comments

@edmundmiller
Copy link
Contributor

A follow-up to #662.

  1. We need to think about the paths, and how users will install.

This one I haven't made a choice on. Currently, all the subworkflows don't work because the file paths in them are, for example, ../../modules/nf-core/software/samtools/stats/main but that nf-core isn't in the path. The double nested directories aren't my favorite, but I think they keep it consistent between this repo and the pipelines, so we don't have to sed all the include paths when installing. We'd have to move all the modules, which we should wait to do a second PR for, so we can verify the testing works in this one because moving everything is going to invoke #391.

  1. We need to come up with a standard meta.yml for subworkflows and if there's anything different.
  2. Some way to track down all the nf-core subworkflows that are floating in the pipelines
@mashehu
Copy link
Contributor

mashehu commented Oct 8, 2021

ad 3.) Do you mean something like this nf-core/website#834 ? Or more something from the nf-core/tools side?

@edmundmiller
Copy link
Contributor Author

No I just meant like GitHub issues, project or milestone to track the progress and creation of them. I think in the future yes something that ingests the meta.ymls and displays it on the site would be nice.

@louperelo louperelo added the stale Stale label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale
Projects
None yet
Development

No branches or pull requests

3 participants