Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Fix bioconda recipe for deepvariant #1754

Open
maxulysse opened this issue Feb 19, 2021 · 5 comments
Open

[FEATURE] Fix bioconda recipe for deepvariant #1754

maxulysse opened this issue Feb 19, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@maxulysse
Copy link
Member

Latest release is 1.1.0.
Latest available on bioconda is: 1.0.0

@maxulysse maxulysse added the enhancement New feature or request label Feb 19, 2021
@maxulysse maxulysse self-assigned this Feb 19, 2021
@abhi18av
Copy link
Member

abhi18av commented Jul 6, 2021

Hi @maxulysse

As some background work for nf-core/sarek#394 I had a look at the deepvariant container available in biocontainers and conda, however they don't bundle the run_deepvariant.py wrapper utility which was released last year.

For the purpose of the module, I'm relying on Google's container for deepvariant and once the module design is finalized, I'll try to accomodate those changes in conda version of deepvariant recipe.

@FriederikeHanssen
Copy link
Contributor

Hey @abhi18av ! What is the status here?

@abhi18av
Copy link
Member

Hi @FriederikeHanssen ,

This is a tough nut, I have initiated an issue on the bioconda side bioconda/bioconda-recipes#30310 and taken a stab at the recipe here https://github.com/bioconda/bioconda-recipes/pull/30311/files, however I found the build script to be a bit convoluted and contacted the core authors through the issue.

Haven't heard back from them regarding the inclusion of run_deepvariant script. However, on the nf-core/modules side (#572 ) the docker and singularity builds directly use the official Google containers which are passing the tests.

@FriederikeHanssen
Copy link
Contributor

ok, then let's leave this issue open :) Thank you, I tried to clean up a bit before tomorrow

@FriederikeHanssen
Copy link
Contributor

Should we move this issue to modules? Not exactly a sarek related one

@maxulysse maxulysse transferred this issue from nf-core/sarek Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants