Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking if shards > 0 are present before firing tests #484

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Dec 12, 2024

PR checklist

  • Checking if shards > 0 are present before firing tests
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@GallVp GallVp requested a review from a team as a code owner December 12, 2024 04:09
@GallVp GallVp requested a review from sateeshperi December 12, 2024 04:09
@GallVp
Copy link
Member Author

GallVp commented Dec 12, 2024

Hi @sateeshperi

I'm going to create one more PR with one CPU test touched to ensure that it works.

Copy link

github-actions bot commented Dec 12, 2024

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit 7309cb6

+| ✅ 201 tests passed       |+
#| ❔   5 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-12-12 04:10:35

@sateeshperi
Copy link
Contributor

i have another PR coming in case we need to the when shards > 0

@GallVp
Copy link
Member Author

GallVp commented Dec 12, 2024

This can be merged now. I verified that the CI still works when there are changes: #485

@sateeshperi sateeshperi merged commit fb03325 into dev Dec 12, 2024
10 checks passed
@sateeshperi sateeshperi deleted the fix/ci branch December 12, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants