Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using FASTA_GXF_BUSCO_PLOT sub workflow #77

Open
GallVp opened this issue Oct 31, 2024 · 7 comments · May be fixed by #96
Open

Using FASTA_GXF_BUSCO_PLOT sub workflow #77

GallVp opened this issue Oct 31, 2024 · 7 comments · May be fixed by #96
Assignees

Comments

@GallVp
Copy link
Member

GallVp commented Oct 31, 2024

Hello Team!

I built a reusable sub workflow for performing BUSCO on genome alone, or on genome and annotation. I have used it in two other pipelines. It is currently sitting in my own modules repo: https://github.com/GallVp/nxf-components/blob/7188d37139f8dbdfd73cbfb5b0e3f811d1993392/subworkflows/gallvp/fasta_gxf_busco_plot/main.nf#L7

I think we should be sharing this across pipelines. I can submit it to nf-core/modules and add it here. Checking if there is interest here and if there is need to modify it to suite the needs of this pipeline?

@GallVp GallVp self-assigned this Oct 31, 2024
@chriswyatt1
Copy link
Contributor

That looks really useful, will check it out next week.

@FernandoDuarteF
Copy link
Collaborator

I think we should definitively incorporate this to our pipeline.

I was also thinking we should make genome.nf and genome_and_annotation.nf into workflows, as right now they are subworkflows.

@FernandoDuarteF
Copy link
Collaborator

We should also have a look at the BUSCO subworkflow from the MAG pipeline. See #85.

@GallVp
Copy link
Member Author

GallVp commented Nov 8, 2024

We should also have a look at the BUSCO subworkflow from the MAG pipeline. See #85.

My implementation does have a val_busco_lineages_path input. If this is provided, busco will download the data there once and will reuse it. If all the data is already downloaded, then busco will use that instead of redownloading it.

For cloud environments, this parameter needs to be optimised so that a tar ball can be passed similar to what mag is doing.

@FernandoDuarteF
Copy link
Collaborator

Hi @GallVp, I would like to incorporate your BUSCO subworkflow into our pipeline, at least for now. We can update it later once it's made into an nf-core subworkflow.

I'm not sure what's the etiquette to follow here, especially when it comes to giving you proper credit.

@GallVp
Copy link
Member Author

GallVp commented Nov 21, 2024

Thank you @FernandoDuarteF

It will be good to share the workflows across pipelines and maintain them jointly. I am happy to create a PR and that will put me as a contributor on the repo. That's enough credit for me. How about we do the following,

  • I submit the sub-workflow to nf-core/modules and invite your review. Hopefully, it will be accepted now that there are two pipelines using it. If not, we will have to maintain it where it is, i.e. in my modules repo.
  • I create a PR to genomeqc for adding the sub-workflow and again invite your review.

@FernandoDuarteF
Copy link
Collaborator

Thank you @GallVp! Awesome, let's do that then.

@GallVp GallVp linked a pull request Nov 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants