Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: template update for nf-core/tools version 3.0.2 #84

Merged
merged 4 commits into from
Oct 24, 2024
Merged

chore: template update for nf-core/tools version 3.0.2 #84

merged 4 commits into from
Oct 24, 2024

Conversation

znorgaard
Copy link
Collaborator

@znorgaard znorgaard commented Oct 17, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fastquorum branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nf-core-bot and others added 2 commits October 17, 2024 14:22
@nf-core-bot @znorgaard
Template update for nf-core/tools version 3.0.0
0816bf3 
Template update for nf-core/tools version 3.0.1

Template update for nf-core/tools version 3.0.2
@znorgaard
chore: enable plotting
f74c63e
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit f9037c4

+| ✅ 194 tests passed       |+
#| ❔   8 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-24 15:36:56

@znorgaard znorgaard removed the request for review from SPPearce October 17, 2024 22:20
@znorgaard znorgaard marked this pull request as ready for review October 17, 2024 22:36
SPPearce
SPPearce reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think there is a merge issue in the configs, but otherwise looks good.

conf/base.config Outdated Show resolved Hide resolved
conf/base.config Show resolved Hide resolved
conf/test.config Outdated Show resolved Hide resolved
SPPearce
SPPearce approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@znorgaard znorgaard merged commit 5d7af8b into dev Oct 24, 2024
9 checks passed
@znorgaard znorgaard mentioned this pull request Oct 24, 2024
Closed
@znorgaard znorgaard deleted the zn_3.0.2_template_merge branch October 24, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees

@SPPearce SPPearce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@znorgaard @SPPearce @nf-core-bot