Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message for metagenomic screening not clear #828

Closed
4 of 5 tasks
aidaanva opened this issue Jan 31, 2022 · 1 comment · Fixed by #842
Closed
4 of 5 tasks

Message for metagenomic screening not clear #828

aidaanva opened this issue Jan 31, 2022 · 1 comment · Fixed by #842
Assignees
Labels
bug Something isn't working minor next-patch

Comments

@aidaanva
Copy link
Contributor

aidaanva commented Jan 31, 2022

Check Documentation

I have checked the following places for your error:

Description of the bug

Steps to reproduce

Steps to reproduce the behaviour:

  1. Command line: nextflow run nf-core/eager -c /bla/bla/screening_.config -profile eva,archgen,big_data,hops_phiX -r 2.4.2 --input /bla/bla/input.tsv --outdir /bla/bla/output --run_metagenomic_screening + all other parameters for metagenomics screening
  2. See error: Please provide your error message
    [nf-core/eager] error: metagenomic classification can only run on unmapped reads. Please supply --bam_unmapped_type 'fastq'. Supplied: --bam_unmapped_type 'discard'.

Expected behaviour

When --run_metagenomic_screening is given however no bam filtering has been turn on, the message is unclear and it only mentions to set up the --bam_unmapped_type to 'fastq'. It should also remind you to turn on --run_bam_filtering

Log files

Have you provided the following extra information/files:

  • The command used to run the pipeline
  • The .nextflow.log file
  • The exact error:

System

  • Hardware:
  • Executor:
  • OS:
  • Version

Nextflow Installation

  • Version:

Container engine

  • Engine:
  • version:
  • Image tag:

Additional context

@aidaanva aidaanva added the bug Something isn't working label Jan 31, 2022
@jfy133 jfy133 self-assigned this Feb 1, 2022
@jfy133 jfy133 added the minor label Feb 1, 2022
@jfy133
Copy link
Member

jfy133 commented Feb 1, 2022

If we need to do another patch release for a major bug, I'll throw this in. Otherwise we will make sure that this is fixed in our DSL2 conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor next-patch
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants