Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation checks fail on TSV when object null() #723

Closed
2 tasks done
jfy133 opened this issue Apr 13, 2021 · 0 comments
Closed
2 tasks done

Input validation checks fail on TSV when object null() #723

jfy133 opened this issue Apr 13, 2021 · 0 comments
Assignees
Labels
bug Something isn't working pending Addressed on branch waiting for related PR

Comments

@jfy133
Copy link
Member

jfy133 commented Apr 13, 2021

Check Documentation

I have checked the following places for your error:

Description of the bug

A user forgot to add NA in the their BAM column, and the TSV file also didn't use quote wrapping. The current input validation only checks ifEmpty() which doesn't seem to work on null() objects.

Steps to reproduce

Make input TSV with empty cell instead of NA.

Should result in

Cannot invoke method isEmpty() on null object

error.

Expected behaviour

The validation check should also die when null() object, and give informative error message.

Additional context

https://stackoverflow.com/questions/25039270/how-to-groovy-ify-a-null-check

@jfy133 jfy133 added the bug Something isn't working label Apr 13, 2021
@jfy133 jfy133 self-assigned this Apr 13, 2021
@jfy133 jfy133 added this to the 2.3.5 patch release milestone May 12, 2021
@jfy133 jfy133 mentioned this issue May 12, 2021
11 tasks
@jfy133 jfy133 added the pending Addressed on branch waiting for related PR label May 12, 2021
@jfy133 jfy133 closed this as completed May 14, 2021
@jfy133 jfy133 mentioned this issue Jun 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending Addressed on branch waiting for related PR
Projects
None yet
Development

No branches or pull requests

1 participant