Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest 'best practise' aDNA mapping parameters #722

Closed
jfy133 opened this issue Apr 13, 2021 · 2 comments
Closed

Update latest 'best practise' aDNA mapping parameters #722

jfy133 opened this issue Apr 13, 2021 · 2 comments
Labels
enhancement New feature or request partially-fixed pending Addressed on branch waiting for related PR
Milestone

Comments

@jfy133
Copy link
Member

jfy133 commented Apr 13, 2021

Is your feature request related to a problem? Please describe

A new publication was just published describing more in-depth parameter modelling to find the most optimal paramaters for mapping with a range of mappers.

Of note they find the best parameters for BWA are turnning of seeding, -n 0.01, and a gap -o 2. I also just noted this is also what was selected by the old as F Mammoth

Describe the solution you'd like

Consider updating default mapping paramaters to reflect the above, and add the gap parameter

Describe alternatives you've considered

Leave it as it is, as the papers don't disagree and we don't know which is best.

Additional context

@jfy133 jfy133 added the enhancement New feature or request label Apr 13, 2021
@jfy133
Copy link
Member Author

jfy133 commented May 12, 2021

We can at least add the bwa -o parameter to bwa options, even if we don't modify defaults

@jfy133 jfy133 mentioned this issue May 12, 2021
11 tasks
@jfy133 jfy133 added this to the 2.3.5 patch release milestone May 12, 2021
@jfy133 jfy133 added partially-fixed pending Addressed on branch waiting for related PR labels May 12, 2021
@jfy133 jfy133 mentioned this issue Jun 2, 2021
11 tasks
@jfy133
Copy link
Member Author

jfy133 commented Aug 25, 2021

Updated bwa aln to recommendations from Oliva et al.

@jfy133 jfy133 closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request partially-fixed pending Addressed on branch waiting for related PR
Projects
None yet
Development

No branches or pull requests

1 participant