Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastq trimming functionality #431

Closed
aidaanva opened this issue May 28, 2020 · 7 comments · Fixed by #765
Closed

Add fastq trimming functionality #431

aidaanva opened this issue May 28, 2020 · 7 comments · Fixed by #765
Labels
enhancement New feature or request pending Addressed on branch waiting for related PR
Milestone

Comments

@aidaanva
Copy link
Contributor

Allow for the trimming at the fastq level to allow for a more stringent mapping. Programs that could be used are: FASTP (https://github.com/OpenGene/fastp#global-trimming) and FastX_trimmer (https://anaconda.org/bioconda/fastx_toolkit)

@aidaanva aidaanva added the enhancement New feature or request label May 28, 2020
@apeltzer
Copy link
Member

Please fastp if possible ;-) That is already implemented and could just be extended 👍

@jfy133 jfy133 added this to the V2.3 "Wangen" milestone Jun 1, 2020
@jfy133
Copy link
Member

jfy133 commented Jun 1, 2020

Problem with FASTP is that it happens before poly-G trimming. This might be OK as I suspect you would only need to do FASTQ trimming after evaluating your libraries, so you would trim on a re-run of previously run data.

FASTQ trimming is not commonly done in all aDNA fields, so pushing back 2.3 until can evaluate this fully.

@jfy133
Copy link
Member

jfy133 commented Jun 23, 2020

@aidaanva this is now avaliable when using BowTie2 (as I found it offers it integrated). As Bowtie2 is apparently slightly better (https://www.frontiersin.org/articles/10.3389/fevo.2020.00105/full), I think this would be sufficient. If you absolutely need this independently later on, please re-open this issue.

@jfy133 jfy133 closed this as completed Jun 23, 2020
@aidaanva
Copy link
Contributor Author

Does that mean that I need to use bowtie as a mapper? What about if you want to use bwa?

@aidaanva aidaanva reopened this Mar 19, 2021
@meganemichel
Copy link

meganemichel commented Mar 19, 2021

It would be great to add functionality for trimming damage/barcodes prior to mapping without requiring use of bowtie as the mapper. Currently it does not seem to be possible to trim damage/barcodes using bowtie and map with bwa in the same run. Instead this requires two separate eager runs.

@jfy133
Copy link
Member

jfy133 commented Mar 19, 2021

I'm still not convinced we need to add a whole new tool and process for this. Like I said above, BowTie2 already does trimming and mapping for you (and performs better it seems!).

In terms of damage, you would already have to have it run once to know how much damage to remove, but please see #632 for adapters - this will at least be implemented as this is a more important issue.

@jfy133
Copy link
Member

jfy133 commented Mar 19, 2021

Sorry, I just should say that of course you are both welcome to make a PR to add it if you really really think BT2 is not comaptible for your data.!

@jfy133 jfy133 added the pending Addressed on branch waiting for related PR label Jul 18, 2021
@jfy133 jfy133 linked a pull request Jul 26, 2021 that will close this issue
11 tasks
@jfy133 jfy133 closed this as completed Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pending Addressed on branch waiting for related PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants