Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include test of PE data #189

Closed
k1sauce opened this issue May 16, 2024 · 2 comments
Closed

Include test of PE data #189

k1sauce opened this issue May 16, 2024 · 2 comments
Assignees
@nschcolnicov
Labels
enhancement Improvement for existing functionality
Milestone
1.5.0

Comments

@k1sauce
Copy link
Contributor

k1sauce commented May 16, 2024

Description of feature

There is some logic around handling of PE and SE fastq files, would be nice to have a test for this as well.
@k1sauce k1sauce added the enhancement Improvement for existing functionality label May 16, 2024
@grst
Copy link
Member

grst commented Jul 18, 2024

As discussed with @atrigila and @nschcolnicov fixing this would entail adding a test case to https://github.com/nf-core/demultiplex/tree/master/tests/pipeline that runs as part of the CI.

@nschcolnicov nschcolnicov moved this from Todo - high priority to In Progress in nf-core/demultiplexing project board Jul 29, 2024
@nschcolnicov nschcolnicov self-assigned this Jul 29, 2024
This was referenced Jul 30, 2024
Merged
Merged
@nschcolnicov nschcolnicov moved this from In Progress to On hold in nf-core/demultiplexing project board Jul 31, 2024
@nschcolnicov
Copy link
Contributor

Addressing this issue in this PR: #214

@apeltzer apeltzer added this to the 1.5.0 milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nschcolnicov nschcolnicov

Labels
enhancement Improvement for existing functionality
Projects
nf-core/demultiplexing project board
Status: Done
Milestone
1.5.0
Development

No branches or pull requests
4 participants
@apeltzer @grst @k1sauce @nschcolnicov