Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report plots docs #75

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Report plots docs #75

merged 3 commits into from
Oct 25, 2023

Conversation

mirpedrol
Copy link
Member

Document output plots added with #74

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/crisprseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 62cab5f

+| ✅ 154 tests passed       |+
#| ❔  16 tests were ignored |#
!| ❗   2 tests had warnings |!
-| ❌   4 tests failed       |-

❌ Test failures:

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: If applicable, make list of people who have also contributed
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-25 07:15:01

@mirpedrol mirpedrol added this to the 2.1.0 milestone Sep 19, 2023
LaurenceKuhl
LaurenceKuhl requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@LaurenceKuhl LaurenceKuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few typos otherwise lgtm :)

docs/output/targeted.md Outdated Show resolved Hide resolved
docs/output/targeted.md Outdated Show resolved Hide resolved
docs/output/targeted.md Outdated Show resolved Hide resolved
@mirpedrol mirpedrol merged commit c687eba into nf-core:dev Oct 25, 2023
9 of 10 checks passed
@mirpedrol mirpedrol deleted the report-plots-docs branch October 25, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenceKuhl LaurenceKuhl LaurenceKuhl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @LaurenceKuhl