Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metro map #327

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Add metro map #327

merged 5 commits into from
Jan 5, 2023

Conversation

G-Sarah
Copy link
Contributor

@G-Sarah G-Sarah commented Jan 5, 2023 •
edited
Loading

Added the metro map to README.md.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/chipseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

maxulysse
maxulysse reviewed Jan 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Jan 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple comments but looks good to me

@github-actions
Copy link

github-actions bot commented Jan 5, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 183b641

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-01-05 16:16:03

maxulysse
maxulysse approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@G-Sarah G-Sarah merged commit e5dcac8 into dev Jan 5, 2023
@G-Sarah G-Sarah deleted the add-metro-map branch January 5, 2023 16:50
@JoseEspinosa JoseEspinosa mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G-Sarah @maxulysse