Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UMI subworkflow #130

Merged
merged 11 commits into from
Aug 4, 2021
Merged

UMI subworkflow #130

merged 11 commits into from
Aug 4, 2021

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Aug 3, 2021 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/bcellmagic branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ggabernet ggabernet mentioned this pull request Aug 3, 2021
Merged
19 tasks
dladd
dladd approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@dladd dladd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me- adds flexibility and extendibility and should make it relatively straightforward for me to add the no-umi option- thanks @ggabernet !

conf/modules.config Show resolved Hide resolved
@ggabernet ggabernet merged commit 401e79e into nf-core:dev Aug 4, 2021
@ggabernet ggabernet deleted the no_umi branch December 1, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dladd dladd dladd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggabernet @dladd