Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass API key for vector tiles via Tangram globals parameter #334

Closed
rfriberg opened this issue Jan 5, 2017 · 5 comments
Closed

Pass API key for vector tiles via Tangram globals parameter #334

rfriberg opened this issue Jan 5, 2017 · 5 comments
Assignees

Comments

@rfriberg
Copy link
Contributor

rfriberg commented Jan 5, 2017

Pass the required API key (see #332) (which may be overwritten in tangramOptions) to the included Mapzen basemap style for use with vector tiles. This may be done via global parameters in Tangram.js.

@nvkelso
Copy link
Contributor

nvkelso commented Jan 6, 2017

Related Cartography documentation work here:

Example usage in Bubble Wrap:

Because the Mapzen basemap styles are versioned, and this will be a breaking change with a new major version I will publish the new styles at my leisure (probably next week?), but we will need to land support for the API key in Mapzen.js (this issue) before I update the house style major versions config in Mapzen.js.

@hanbyul-here
Copy link
Contributor

also some related discussion ( Some concerns + ideas about how to integrate apiKey to tiles were raised while making L.Mapzen.apiKey : https://github.com/mapzen/mapzen.js/pull/321

I think it might be better to keep the way to pass the apikey, and make L.Mapzen.apiKey's jobs to handle all apikey underneath? (rather than making new spot to pass api key?)

@rfriberg
Copy link
Contributor Author

rfriberg commented Jan 9, 2017

@nvkelso - is the global parameter you're using for the basemap styles called sdk_mapzen_api_key or sdk_api_key. I'm seeing both in tangrams/cartography-docs#2 (comment) discussion.

Also, can you let us know when you publish (at least one of) the basemap updates so we can test?

@rfriberg rfriberg self-assigned this Jan 9, 2017
@hanbyul-here
Copy link
Contributor

closing with 7a29849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants