Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in how Ns are handled for genes vs nucleotide view #730

Closed
corneliusroemer opened this issue Feb 14, 2022 · 3 comments
Closed
Labels
package: nextclade_web t:talk Type: discussion of the application or the science behind it

Comments

@corneliusroemer
Copy link
Member

When I upload a partial genome, it is not evident in gene view that there are missing parts. It looks like the sequence is equal to reference in parts that are cut out.

image

The same is true for the column Ns or missing. It doesn't count missing parts of the genome.

In nucleotide view, however, unsequenced parts are marked up and distinguishable (grey, with tooltip).

image

It may be good to surface missing beginnings and ends in gene view and in the Ns column tooltip. I think we have the information, it should be available through alignment start/end. It could be displayed in the same tooltip but under a separate heading (as missing start/end) and maybe counted in parentheses (like we display known frame shifts).

@corneliusroemer corneliusroemer added t:talk Type: discussion of the application or the science behind it needs triage Mark for review and label assignment package: nextclade_web labels Feb 14, 2022
@corneliusroemer
Copy link
Member Author

corneliusroemer commented Feb 14, 2022

To reproduce, you can use this sequence
short.txt

Or this one, maybe better since it contains some S mutations
short.txt

@ivan-aksamentov
Copy link
Member

missing beginnings and ends

They are mentioned in the alignment start and end. However it is unclear how to map that to aminoacids.

@ivan-aksamentov ivan-aksamentov removed the needs triage Mark for review and label assignment label Mar 12, 2022
@corneliusroemer
Copy link
Member Author

Spotted someone raising this issue independently in the wild. Would be great if we could display alignmentStart/End on the gene view
cov-lineages/pango-designation#843 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: nextclade_web t:talk Type: discussion of the application or the science behind it
Projects
No open projects
Status: Backlog
Development

No branches or pull requests

2 participants