Handle potential errors in footer parsing

[jameshadfield]

I've implemented Error Boundaries in a few places, but not consistently and not that well. Since we do a lot of data processing on the client, we are prone to errors which may bring the app (client) down. One such place is in the parsing of footer markdown. The output of this should be wrapped in an Error Boundary (or a simple try/catch used as we parse the data.

[andressrudqvist]

Hi James,

I would like to work on this issue. I think that something like this would do the job.

    let cleanDescription;
    try 
    {
      const rawDescription = marked(metadata.description);
      cleanDescription = sanitizer(rawDescription, sanitizerConfig);
    } catch (error) {
      console.error('Error parsing footer description'+error)      
      cleanDescription = (<h1>Something went wrong.</h1>);
    }

Regards,

Andres

[jameshadfield]

Yes, I think this would be good 👍

Let's change <h1>Something went wrong</h1> to <p>There was an error parsing the footer description.</p> or similar.

[andressrudqvist]

Hi James,

I modified the message. I made a branch and the modified code is.

[jameshadfield]

Great! Can you make a PR into this repo so I can test & merge?

[andressrudqvist]

Hi James, the PR is already merged. As part of this issue would you like me to implement Error Boundaries in other key components?

Andres

[andressrudqvist]

For reference this is the PR URL:
#1058

[jameshadfield]

Closed by #1058