Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cumulative map animation should be able to start at user selection #380

Closed
jameshadfield opened this issue Jul 10, 2017 · 4 comments
Closed
Labels
enhancement New feature or request revisit sometime Useful to address but no bandwidth at the moment

Comments

@jameshadfield
Copy link
Member

steps to explain

  • go to zika
  • toggle cumulative animation on
  • drag maxDate slider back to (say) half way
  • begin animation

Current behavior: animation starts from beginning (i.e. maxDate jumps back to ~minDate)

Proposed behavior: animation starts from user selected time slice

Caveats: clearly if maxDate is at (or near?) the end of the available time we should start the animation from the beginning.

@jameshadfield jameshadfield added the enhancement New feature or request label Jul 10, 2017
@colinmegill
Copy link
Collaborator

Interesting, I thought this worked, I suppose it doesn't in this case. If cumulative is toggled while the animation is running (with a time window, not cumulative) cumulative does pick up where it left off.

@trvrb
Copy link
Member

trvrb commented Jul 11, 2017

Yeah. This is tricky. Thinking about this in terms of UX with least surprise...

If you do a "cumulative" animation when dateMax is all the way right, dateMax jumps left and increments from there. This makes sense. If it jumps left when the bar is full, why wouldn't it jump left when the bar is half full?

I'm not super confident here, but I lean toward preserving current behavior.

@jameshadfield jameshadfield added the revisit sometime Useful to address but no bandwidth at the moment label Jul 11, 2017
@jameshadfield
Copy link
Member Author

jameshadfield commented Jul 11, 2017

If it jumps left when the bar is full, why wouldn't it jump left when the bar is half full?

If someones modified the date slider, then one could make the case for a different behavior.

Added the "revisit" label as this is currently very low priority

@jameshadfield
Copy link
Member Author

Closing this as the current behavior is perfectly acceptable 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request revisit sometime Useful to address but no bandwidth at the moment
Projects
None yet
Development

No branches or pull requests

3 participants