Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify action dispatch #348

Closed
jameshadfield opened this issue Jun 29, 2017 · 1 comment
Closed

Simplify action dispatch #348

jameshadfield opened this issue Jun 29, 2017 · 1 comment

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Jun 29, 2017

This issue is to highlight the number of actions being dispatched, which is often hard to determine. In general, reducing the number of dispatched actions (i.e. by making fewer actions with more effects) seems to solve a lot of bugs. This should be our general aim going forward.

Please update this table when necessary.

Last updated @ commit 4e27c43

function n(dispatches) // calls
updateColors 1
changeColorBy updateColors
populateEntropyStore 1
loadMetaAndTreeAndSequencesJSONs 2 + updateVisibleTipsAndBranchThicknesses + updateColors (total = 4)
updateVisibleTipsAndBranchThicknesses 1 + some anti-pattern modification of redux state
changeDateFilter 1 + some anti-pattern modification of redux state
populateFrequenciesStore 2 or 3
updateTipRadii 1
legendMouseEnterExit 1 + updateTipRadii
applyFilterQuery 1 + updateVisibleTipsAndBranchThicknesses
toggleTemporalConfidence 1 (not a thunk!)
loadJSONs 1 + loadMetaAndTreeAndSequencesJSONs + populateEntropyStore (total = 6)
@jameshadfield jameshadfield mentioned this issue Jun 29, 2017
@trvrb trvrb added the Epic label Jul 7, 2017
@trvrb trvrb changed the title Number of actions being dispatched Simplify action dispatch Jul 7, 2017
@jameshadfield
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants