Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting following crash/whiteout, probably since Auspice 2.60.0: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator)) #1895

Closed
corneliusroemer opened this issue Nov 12, 2024 · 5 comments · Fixed by #1898
Closed

Getting following crash/whiteout, probably since Auspice 2.60.0: TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator)) #1895

corneliusroemer opened this issue Nov 12, 2024 · 5 comments · Fixed by #1898
Assignees
@jameshadfield
Labels
bug Something isn't working priority: high To be resolved before other issues

Comments

@corneliusroemer
Copy link
Member

corneliusroemer commented Nov 12, 2024 •
edited
Loading

Current Behavior

I've hit the following whiteout crash of Auspice multiple times today - I don't remember ever seeing a whiteout like this (at least not in the past few months) so this must be due to a recent change in a recent release.

I've also hit it on Nextclade master: nextstrain/nextclade#1547 which uses 2.60.0 as well.

I hit it multiple times not thinking anything, just reloading the page. Only after filing the Nextclade issue did I look at the console and realized that this is probably an Auspice bug, not a Nextclade bug.

17:11:23.630 auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2 TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at B (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:2310)
    at Y._setSelectedNodes (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:7380)
    at Y.update (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:5079)
    at l.value (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:37588)
    at Ei (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:65453)
    at Ua (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:83928)
    at Es (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:120612)
    at Tu (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:112074)
    at Su (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:111999)
    at vu (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:109025)

We might want to revert to 2.59.1 unless we have a quick fix for this as it has come up independently around 5 times or more already today. I've added priority: high for now.

Unfortunately I don't know how to reproduce it (yet). Example tree where I encountered this: https://next.nextstrain.org/fetch/genome-test.gi.ucsc.edu/trash/hgPhyloPlace/subtreeAuspice11_genome_test_55b41_3699e0.json?c=gt-nuc_2091&gmax=17887&gmin=15887&gt=nuc.1674C&label=id:node_7178235 - but not limited to this tree, I've encountered it on a variety of trees.

Tree JSON:
fetch_genome-test.gi.ucsc.edu_trash_hgPhyloPlace_subtreeAuspice11_genome_test_55b41_3699e0.json.json

Error points at _setSelectedNodes being involved which is in this file:

auspice/src/components/entropy/entropyD3.js

Line 191 in e8337a8

EntropyChart.prototype._setSelectedNodes = function _setSelectedNodes() {
which was also recently changed. So might be related to some of @jameshadfield's recent perf improvements.

17:11:23.630 auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2 TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at B (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:2310)
    at Y._setSelectedNodes (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:7380)
    at Y.update (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:5079)
    at l.value (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:37588)
    at Ei (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:65453)
    at Ua (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:83928)
    at Es (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:120612)
    at Tu (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:112074)
    at Su (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:111999)
    at vu (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:109025)
as @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
n.callback @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
gi @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
fs @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Cu @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
t.unstable_runWithPriority @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
$o @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Ou @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
vu @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
t.unstable_runWithPriority @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
$o @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Qo @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Xo @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
mu @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
notify @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
notifyNestedSubs @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
o @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
g @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
dispatch @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
dispatch @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
value @ auspice.chunk.928.bundle.41a3efacc6aed0cf56e5.js:2
(anonymous) @ auspice.chunk.928.bundle.41a3efacc6aed0cf56e5.js:2
v @ auspice.chunk.other-vendors.bundle.160c684012f52edf64fc.js:2
x @ auspice.chunk.other-vendors.bundle.160c684012f52edf64fc.js:2
w @ auspice.chunk.other-vendors.bundle.160c684012f52edf64fc.js:2
17:11:23.631 auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2 Uncaught TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at B (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:2310)
    at Y._setSelectedNodes (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:7380)
    at Y.update (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:5079)
    at l.value (auspice.chunk.387.bundle.9cd3699284d72342714a.js:1:37588)
    at Ei (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:65453)
    at Ua (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:83928)
    at Es (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:120612)
    at Tu (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:112074)
    at Su (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:111999)
    at vu (auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2:109025)
B @ auspice.chunk.387.bundle.9cd3699284d72342714a.js:1
Y._setSelectedNodes @ auspice.chunk.387.bundle.9cd3699284d72342714a.js:1
Y.update @ auspice.chunk.387.bundle.9cd3699284d72342714a.js:1
value @ auspice.chunk.387.bundle.9cd3699284d72342714a.js:1
Ei @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Ua @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Es @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Tu @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Su @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
vu @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
t.unstable_runWithPriority @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
$o @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Qo @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
Xo @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
mu @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
notify @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
notifyNestedSubs @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
o @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
g @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
dispatch @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
dispatch @ auspice.core-vendors.bundle.4653d4d814c0c7bfd800.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
(anonymous) @ auspice.chunk.251.bundle.fd436d89122437304aeb.js:2
value @ auspice.chunk.928.bundle.41a3efacc6aed0cf56e5.js:2
(anonymous) @ auspice.chunk.928.bundle.41a3efacc6aed0cf56e5.js:2
v @ auspice.chunk.other-vendors.bundle.160c684012f52edf64fc.js:2
x @ auspice.chunk.other-vendors.bundle.160c684012f52edf64fc.js:2
w @ auspice.chunk.other-vendors.bundle.160c684012f52edf64fc.js:2
@corneliusroemer corneliusroemer added bug Something isn't working priority: high To be resolved before other issues labels Nov 12, 2024
@corneliusroemer corneliusroemer mentioned this issue Nov 12, 2024
Closed
@ivan-aksamentov
Copy link
Member

I tried to repro, but could not. It probably takes some scrolling to the entropy panel and back (making it visible and invisible) and then also "selecting" some nodes. Clicking on nodes did not repro it immediately.

@corneliusroemer corneliusroemer mentioned this issue Nov 12, 2024
Closed
@corneliusroemer

This comment was marked as off-topic.

Sign in to view
@ivan-aksamentov
Copy link
Member

Alright, got a repro:

  • load the link in the first message (this one)
  • click on branch
  • filter a sample, e.g. from Germany
  • notice "data is loading" in entropy panel
  • resize window
  • notice crash
Peek.2024-11-12.17-33.m.mp4

@ivan-aksamentov

This comment was marked as resolved.

Sign in to view
@ivan-aksamentov ivan-aksamentov mentioned this issue Nov 12, 2024
Merged
@corneliusroemer

This comment was marked as resolved.

Sign in to view
@victorlin victorlin mentioned this issue Nov 12, 2024
Merged
2 tasks
@jameshadfield jameshadfield self-assigned this Nov 12, 2024
@jameshadfield jameshadfield mentioned this issue Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameshadfield jameshadfield

Labels
bug Something isn't working priority: high To be resolved before other issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix in Entropy panel when window resizes nextstrain/auspice
3 participants
@jameshadfield @ivan-aksamentov @corneliusroemer