-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gene order in genotype color-by customizable #1549
Comments
They are only alphabetical because that's how augur is exporting them -- the order they appear in the Note: This relies on stable key ordering going from JSON to JS. This isn't always the case -- for instance, a gene name which is a (string) integer will be lifted to the top of the order. I'm not aware of any genes which are integers, so for our purposes I think we can treat it as stable and avoid a schema change. |
I'm going to close this as nextstrain/augur#1052 should resolve |
Hmm, I was thinking the key ordering in |
JSON objects are technically unordered, but some languages (incl. Python and JS) preserve order when encoding/decoding their native equivalent type to/from JSON objects. So if we care about interop with other JSON encoders/decoders, we may not want to rely on ordering of object fields. |
Linking the Advanced Gene Viewing Options question to this issue |
Context
Related to #1548
Description
Currently, the order of genes in the genotype color-by dropdown option is listed alphabetically, with the exception of "nucleotide" which is added last (which will soon be changed in response to #1548).
Users may want to highlight an antigenically important gene (e.g. the "S" gene in SARS-CoV-2) and display the gene first in the dropdown. We should allow users to customize the display order of genes in this dropdown in the dataset JSON.
The text was updated successfully, but these errors were encountered: