-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable a narrative to source multiple builds #1050
Comments
This would be wonderful. Currently the architecture of auspice is designed around loading a single dataset (code which fetches the JSONs here). This dataset JSON essentially generates most of the redux state needed to display that dataset, via createStateFromQueryOrJSONs. (The way narratives work is that they then use URL queries to modify this redux state when you move between slides, thus affecting how the data should be presented. This is via To allow multiple datasets the redux state (via |
Opened a WIP here #1071 but needs help for comments, test cases, debugging |
Leaving a summary of a comment in #1071 here for posterity also: I've made a test narrative to demonstrate the functionality this issue is asking for: markdown here and visible on nextstrain.org here. This is a simple 3-slide narrative which should change from the mumps dataset to the zika dataset, but it currently does not. To run locally in auspice, you should run |
Posted an update in the PR about 10 days ago, I guess you guys are super busy these days but just wanted to make sure it does not end up flying under the radar @jameshadfield . |
This looks pretty good! I know @eharkins has tested this a bit, so look out for a review from him in the coming days 👍 |
Closed by #1164 |
Context
We publish weekly situation reports using narratives on the spread of COVID-19. These situation reports are broken into sections by world region. Latest report for example: https://nextstrain.org/narratives/ncov/sit-rep/2020-04-03
Currently, narratives can only source one dataset. When there was only one global
ncov
build, this wasn't a problem. Now that we have multiple subsampled builds (ncov/global
,ncov/europe
,ncov/africa
...) using only one of these builds for the situation reports greatly limits the data we can cover.Description
We'd like to upgrade the narratives functionality, so it can source multiple datasets within a single narrative. For example, one slide could show the
ncov/global
build and the next slide could show thencov/north-american
build.Possible solution
There's been some limited discussion about the problem at issue: #890
The text was updated successfully, but these errors were encountered: