Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend service for plugin metadata #34

Open
bentsherman opened this issue Sep 28, 2023 · 9 comments
Open

Backend service for plugin metadata #34

bentsherman opened this issue Sep 28, 2023 · 9 comments

Comments

@bentsherman
Copy link
Member

As the plugin ecosystem grows, it might be better to separate the plugins file into separate files for each plugin. This way Nextflow doesn't have to download the entire file just to get the metadata for a few plugins.

The problem is that older versions of Nextflow won't be able to pull plugins, or they will be stuck on the last version of the all-in-one file and won't be able to pull new plugins.

In any case, I don't think it will be an issue unless there are e.g. thousands of plugins.

@pditommaso
Copy link
Member

I think we should start planning a backend-like system to manage plugins metadata, keep the plugins.json aligned with the new system for backward compatibility and deprecate it

@bentsherman
Copy link
Member Author

And I bet you want to use surrealdb for it? 😄

@pditommaso
Copy link
Member

now you said that, yes!

@drernie
Copy link
Contributor

drernie commented Oct 15, 2023

Is this a hackathon project? I'd be interested in helping, as it may make my merges simpler.

@bentsherman
Copy link
Member Author

We will probably handle this internally since we'll need to host the service anyway.

@bentsherman bentsherman changed the title Split plugins.json into separate file for each plugin Backend service for plugin metadata Nov 2, 2023
@jagedn
Copy link
Contributor

jagedn commented Jul 31, 2024

Hi
Maybe by the moment, split the plugins in different json (one per plugin) and a github action to merge all of them when a pr is merged can be util

@pditommaso
Copy link
Member

Hola Jorge, what would be the benefit?

@jagedn
Copy link
Contributor

jagedn commented Jul 31, 2024

Final result will be the same, I mean, a full json with all plugins+releases but having a source json per plugin can facilitate the track and PRS as every author will edit their own json avoiding conflicts

@bentsherman
Copy link
Member Author

We don't really run into conflicts between different PRs. Updating two different plugins at the same time wouldn't cause a merge conflict. I think splitting the JSON file would just increase the round-trip time. It's not an urgent issue so better to wait until we can build a full solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants