Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smarter typecasting to the samplesheet converter #50

Open
nvnieuwk opened this issue Aug 27, 2024 · 0 comments
Open

Add smarter typecasting to the samplesheet converter #50

nvnieuwk opened this issue Aug 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nvnieuwk
Copy link
Collaborator

nvnieuwk commented Aug 27, 2024

Smarter typecasting should be added to the samplesheet converter to keep the conversion consistent across similar schemas. e.g.:

{
  "type": "string",
  "oneOf": [
    { "format": "file-path" },
    { "const": "hi" }
  ]
}

and

{
  "oneOf": [
    { 
      "type": "string",
      "format": "file-path"
    },
    {
      "type": "string",
      "const": "hi"
    }
  ]
}

Are functionaly the same schemas but they have different results:

  1. Does not convert the file into a file object
  2. Does convert the file into a file object
@nvnieuwk nvnieuwk added the enhancement New feature or request label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant