Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offload publishDir data copy to job script #1002

Closed
pditommaso opened this issue Jan 17, 2019 · 1 comment
Closed

Offload publishDir data copy to job script #1002

pditommaso opened this issue Jan 17, 2019 · 1 comment
Labels

Comments

@pditommaso
Copy link
Member

pditommaso commented Jan 17, 2019

Process data publishing defined by using the publishDir directive is handled by the main nextflow application. This approach does not scale for large workloads because all taks outputs will need to be copied by the same NF instance.

A possible improvement consists off-loading task outputs publishing to the job script wrapper.

This would only be possible for publishDir directive not specifying the saveAs attribute because in this case the closure needs to be evaluated by the NF runtime, therefore it cannot be resolved in the Bash wrapper script.

Also it could only be applied when the publishing target directory is on the same file system as the workflow work directory or the bucket directory.

Suggested implementation:

  1. determine if the publishDir is eligible to be managed at task level;
  2. if yes, add the relevant information here;
  3. generate the appropriate copy command, along the same line of outputFiles;
  4. otherwise fallback on the default behaviour.

Related: #856.

@pditommaso pditommaso changed the title Off-load publishDir data copy to job script Offload publishDir data copy to job script Jan 17, 2019
@stale
Copy link

stale bot commented Apr 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 27, 2020
@pditommaso pditommaso added stale and removed wontfix labels Apr 27, 2020
@stale stale bot closed this as completed Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant