Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[post-mortem] improve yank flow for cargo-nextest #927

Open
1 of 5 tasks
sunshowers opened this issue Aug 2, 2023 · 4 comments
Open
1 of 5 tasks

[post-mortem] improve yank flow for cargo-nextest #927

sunshowers opened this issue Aug 2, 2023 · 4 comments

Comments

@sunshowers
Copy link
Member

sunshowers commented Aug 2, 2023

In #926, it took almost 20 minutes to fully yank the bad version. We need to improve our story here -- yanking a bad release should take under 5 minutes at most.

  • Add test for v0.9.56 Always Fails Due to Missing Config File #926.
  • Move commands from GH Actions to scripts/.
  • Add a mukti-bin yank command.
  • Build automated CI tooling to yank bad versions.
  • Work with Taiki to create a signal to update taiki-e/install-action.
    • Addressed by install-action always using cargo-binstall, making it so that we have control over nextest's releases.
@thomasmost
Copy link

FWIW my GitHub actions flow is still broken, using taiki-e/install-action@nextest

@sunshowers
Copy link
Member Author

sunshowers commented Aug 2, 2023

Ah yes, didn't realize the install-action had picked it up already. Taiki needs to update it on his end: taiki-e/install-action#178

@sunshowers
Copy link
Member Author

You can check in an empty .config/nextest.toml as a temporary workaround.

@thomasmost
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants