-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow only showing stdout or stderr when using --success-output
and --failure-output
#1688
Comments
Thanks! I think the general suggestion makes sense, and I like the In the specific case of the output generated by libtest, I actually want to just start filtering that out -- it's been somewhat annoying for sure. A few things that come to mind:
|
For combined outputs I would expect that it would apply the filter before combining them.
|
Ah sadly that's not possible on Unix. |
Then I would suggest only supporting |
I definitely see where this is coming from! I think that might end up denying too much, though -- especially if specified in configuration this can be quite annoying in practice. Also, we'll likely support combined output not just via libtest (as we do today) but also via per-test settings. I think if at least one test is run with combined output, I would:
Thanks for your help designing this! Would you also like to implement it? Otherwise I can get to this in the next few weeks. |
I'll have a try this weekend 👍 |
I'm writing a file parser and when I get a new version of the format I like to add the samples to my tests.
However, this means that the tests will start hitting todo!() and panic!() and this pollutes the output of the tests:
In these cases stdout has no useful additional information compared to stderr, so I would like to disable it.
I was thinking of the following:
--failure-output immediate
-> outputs both stdout and stderr (current case)--failure-output stdout=never
-> does not output to stdout, uses default for stderr--failure-output stdout=never,stderr=immediate
-> does not output to stdout, immediate output for stderrAnother option is adding more flags.
The text was updated successfully, but these errors were encountered: