Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow Not Saving Selected System TAG #436

Open
skykingisepic opened this issue Jan 9, 2023 · 5 comments · May be fixed by #454
Open

Flow Not Saving Selected System TAG #436

skykingisepic opened this issue Jan 9, 2023 · 5 comments · May be fixed by #454
Labels
enhancement

Comments

@skykingisepic
Copy link

Steps to reproduce

  1. Add new flow when Tag Assigned and File System Tag is tagged with
  2. Select System tag 'pdf'
  3. Keep orig, overwrite existing

Expected behaviour

Active flow shows selected tag

Actual behaviour

Selected Tag disappears, not saved so no pdf created when assigning tag to doc

PDF Converter app

PDF Converter app version: (see apps admin page: /index.php/settings/apps)
1.10.0

Server configuration

Operating system: Ubuntu/RedHat/...

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version:

Nextcloud Version: (see admin page)
25.02

Where did you install Nextcloud from:

Signing status:

Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed
paste the results here.

List of activated apps:

``` If you have access to your command line run e.g.: sudo -u www-data php occ app:list from within your server installation folder ```

Nextcloud configuration:

``` If you have access to your command line run e.g.: sudo -u www-data php occ config:list system from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

</details>

**Are you using external storage, if yes which one:** local/smb/sftp/...

**Are you using encryption:** yes/no

### Server log (data/nextcloud.log)
<details>

Insert your server log here

</details>
@ikonnow
Copy link

ikonnow commented Jan 31, 2023

I am having the same issue with the workflow PDF converter in the newest version of Nextcloud. The PDF files are not being generated and the result is no action. Has there been any progress in finding a solution for this?

@rotdrop
Copy link
Contributor

rotdrop commented Mar 3, 2023 •
edited
Loading

I have an issue which is similar. Actually, I can configure the workflow to be triggered the tag, but then looking at lines

workflow_pdf_converter/lib/Operation.php

Lines 79 to 82 in 814ccb6

public function onEvent(string $eventName, Event $event, IRuleMatcher $ruleMatcher): void {
if (!$event instanceof GenericEvent) {
return;
}

we see that only events of type GenericEvent AKA OCP\EventDispatcher\GenericEvent are handled.

Now, inserting some "printf"-style debugging lines we see that the event which is actually triggered is of class OCP\SystemTag\MapperEvent which extends directly OCP\EventDispatcher\Event and hence is not a GenericEvent.

The MapperEvent also does not directly contain the file-system node but instead -- if the event is related to a file, as determined by getObjectType() -- is able to return the file-id which then would have to be converted to an FS node.

So in short: PDF conversion can at the moment not be triggered by system tags. The necessary changes are straight forward but more involved than just adding a semicolon or two ;)

@rotdrop
Copy link
Contributor

rotdrop commented Mar 3, 2023 •
edited
Loading

Actually, this is also sort of a bug as it is not clear from looking at the UI or the documentation that PDF conversion cannot (yet) be triggered by changing collaborative tags.

@rotdrop rotdrop linked a pull request Mar 3, 2023 that will close this issue
Open
@rotdrop
Copy link
Contributor

rotdrop commented Mar 3, 2023

BTW, part of this issue, namely that the tags were not remembered, is also discussed here nextcloud/server#3564 and probably fixed by 163b86b729fc6cf4105fa7ad95e488e6c5c05532

Still: even with that changer PDF conversion on tag changed cannot work unless something alike #454 is added to this app.

@ostasevych
Copy link

Still not working with tag assigning :( Are any working fixes available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
4 participants
@rotdrop @ostasevych @ikonnow @skykingisepic