Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HEIC HEIF support #4

Closed
skjnldsv opened this issue Feb 26, 2019 · 11 comments
Closed

HEIC HEIF support #4

skjnldsv opened this issue Feb 26, 2019 · 11 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request

Comments

@skjnldsv
Copy link
Member

If possible.
Pulled from specs on nextcloud/server#12382

@skjnldsv skjnldsv added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of 0. Needs triage Pending approval or rejection. This issue is pending approval. and removed 1. to develop Accepted and waiting to be taken care of labels Feb 26, 2019
@skjnldsv skjnldsv changed the title HEIC HEIF HEIC HEIF support Feb 26, 2019
@rullzer
Copy link
Member

rullzer commented Feb 27, 2019

since the viewer only shows preview this will work out of the box if you have a preview provider that can do it 😉

@skjnldsv
Copy link
Member Author

@rullzer what do you mean?
We still need a library to display those files, right?

@rullzer
Copy link
Member

rullzer commented Feb 27, 2019

No we do not. If the preview system generates a preview it will be severed as JPG by the preview system. :)

@skjnldsv
Copy link
Member Author

@rullzer we do not do previews here, we do full view of the file.
If the file is a HEIC and contains multiple files, supporting it in viewer shall display all the content without alteration. :)
That's part of the spec!

@rullzer
Copy link
Member

rullzer commented Feb 27, 2019

Why do we not use the previews? gallery also uses the previews. it is a bit silly to start loading 20mb jpeg files.

@juliusknorr
Copy link
Member

I would also prefer to go for previews by default. We can still integrate some HEIC HEIF javascript viewer later in order to support thinks like burst shots or videos integrated.

@skjnldsv
Copy link
Member Author

@rullzer Well, that is a good discussion to have!
@jancborchardt specifically told me to not use previews since this was supposed to be a file viewer! 🤷‍♀️

Can we move this to another dedicated issue? :)

@jancborchardt
Copy link
Member

specifically told me to not use previews since this was supposed to be a file viewer!

We can always start by displaying the preview as a first implementation or step? The full picture can always be loaded in the background, if necessary. (This is also what we do on Android, and what iOS photos does.)

@ariselseng
Copy link
Member

I opened another issue here, without check this thread first!
#28

Basically any file that has true in the propfind DAV request should use previews. Then we can make exceptions later for animating HEIC or something like that. Preferably with a srcset that would use the best image for the screen.

@dimitrimestdag
Copy link

Still no news on the subject?

@jancborchardt
Copy link
Member

@dimitrimestdag @rkaraba @shllg there is a pull request to implement that at #485 – please give it a test and review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants