-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HEIC HEIF support #4
Comments
since the viewer only shows preview this will work out of the box if you have a preview provider that can do it 😉 |
@rullzer what do you mean? |
No we do not. If the preview system generates a preview it will be severed as JPG by the preview system. :) |
@rullzer we do not do previews here, we do full view of the file. |
Why do we not use the previews? gallery also uses the previews. it is a bit silly to start loading 20mb jpeg files. |
I would also prefer to go for previews by default. We can still integrate some HEIC HEIF javascript viewer later in order to support thinks like burst shots or videos integrated. |
@rullzer Well, that is a good discussion to have! Can we move this to another dedicated issue? :) |
We can always start by displaying the preview as a first implementation or step? The full picture can always be loaded in the background, if necessary. (This is also what we do on Android, and what iOS photos does.) |
I opened another issue here, without check this thread first! Basically any file that has true in the propfind DAV request should use previews. Then we can make exceptions later for animating HEIC or something like that. Preferably with a srcset that would use the best image for the screen. |
Still no news on the subject? |
@dimitrimestdag @rkaraba @shllg there is a pull request to implement that at #485 – please give it a test and review! :) |
If possible.
Pulled from specs on nextcloud/server#12382
The text was updated successfully, but these errors were encountered: