Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix: When previewing some SVG, 'btoa' report error: The string to be encoded contains characters outside of the Latin1 range." #2433

Open
wants to merge 1 commit into
base: stable29
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 20, 2024

Backport of #2432

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from skjnldsv August 20, 2024 09:19
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews labels Aug 20, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.5 milestone Aug 20, 2024
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv skjnldsv marked this pull request as ready for review August 20, 2024 09:20
@skjnldsv skjnldsv mentioned this pull request Aug 20, 2024
9 tasks
This was referenced Aug 29, 2024
@blizzz blizzz mentioned this pull request Sep 4, 2024
3 tasks
@blizzz
Copy link
Member

blizzz commented Sep 5, 2024

conflicts

@AndyScherzinger
Copy link
Member

/compile rebase-amend /

@blizzz
Copy link
Member

blizzz commented Sep 5, 2024

@skjnldsv the css file cannot be rebased due to conflicts.

@skjnldsv
Copy link
Member

skjnldsv commented Sep 5, 2024

/compile amend /

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

…Window': The string to be encoded contains characters outside of the Latin1 range."

When previewing SVG, report error:

`viewer-main.mjs?v=79b66689-10:588 Error evaluating async computed property: Error: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.`

ref: https://stackoverflow.com/questions/23223718/failed-to-execute-btoa-on-window-the-string-to-be-encoded-contains-characte

Signed-off-by: XinRoom <[email protected]>

Signed-off-by: nextcloud-command <[email protected]>
@Altahrim
Copy link

There is a conflict on this one. Can someone take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants