Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to app store #22

Closed
jancborchardt opened this issue Dec 21, 2018 · 9 comments
Closed

Add to app store #22

jancborchardt opened this issue Dec 21, 2018 · 9 comments
Labels
enhancement New feature or request high
Milestone

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Dec 21, 2018

@violoncelloCH @MorrisJobke @rullzer @nextcloud/user_external we should probably put the app in the app store, right?

@violoncelloCH do you want to do that? :)

@jancborchardt jancborchardt added the enhancement New feature or request label Dec 21, 2018
@violoncelloCH
Copy link
Member

Yes, I will try to do this. (Will maybe need some guidance.)
I'm actually reading the documentation on how to publish an app to the appstore :)

@jancborchardt
Copy link
Member Author

@violoncelloCH note down any issue that you encounter, however small it may be! We can use that to improve the flow and documentation for everyone coming after you. ❤️

@violoncelloCH
Copy link
Member

violoncelloCH commented Jan 6, 2019

@jancborchardt
I primarily struggled with the permissions, because the occ integrity:sign-app command needs to be run as www-data, but www-data doesn't have access to the private key, which is saved in my primary user's home directory on my laptop.

The other thing I didn't expect is that occ integrity:sign-app also adds the files in the hidden .git/ directory into signatures.json and there is (AFAIK) no option to exclude this directory. So the only way is to copy the whole folder of the app to another location and then remove .git/ as well??
(For tar i can simply do --exclude .git/)

I now added the first release to the appstore and hope it worked. I guess it simply takes some time or need some manual steps on your (nextcloud's) side? There was no real feedback except a spinning circle on the "Upload" button. The form stayed with the content filled in after the spinning circle disappeared again. Maybe that could be improved in terms of UI design. Also an information text for the first time uploader about when he can expect the app/release to be visible in the appstore would be nice.

If I'm right, I can't set an individual publisher for each app, so the only way to set it to Nextcloud would be to set my whole appstore account to the name "Nextcloud". Should I do this?

@jancborchardt
Copy link
Member Author

Cool! :) Best open these problems as separate issues. The first 2 ones I think go into the server repository cause that’s where the occ command lives. And the 3rd one goes to the appstore.

If I'm right, I can't set an individual publisher for each app, so the only way to set it to Nextcloud would be to set my whole appstore account to the name "Nextcloud". Should I do this?

As @MorrisJobke said in #26 (comment): "Not needed. Just leave it as it is now." – also it would be very confusing if another account would be named "Nextcloud". ;)

@jancborchardt
Copy link
Member Author

Also so far, it said only @icewind1991’s name in there, so it would be good to add him as a collaborator on the appstore interface. :)

@MorrisJobke
Copy link
Member

Also so far, it said only @icewind1991’s name in there, so it would be good to add him as a collaborator on the appstore interface. :)

That is from the info.xml.

And the error you get is not from the appstore, because the app is not uploaded there yet: https://apps.nextcloud.com/apps/user_external

@MorrisJobke
Copy link
Member

See #26 (comment) for the steps.

@violoncelloCH
Copy link
Member

The app is finally released! See https://apps.nextcloud.com/apps/user_external

@jancborchardt
isn't the first point more something for the documentation(s)? occ needs to be run with the webserver user, so it all depends on the filesystem permissions which need to be changed manually.
for the second one I'll create an issue; for the third point @MorrisJobke already created nextcloud/appstore#590

@violoncelloCH
Copy link
Member

for point two: nextcloud/server#13408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high
Projects
None yet
Development

No branches or pull requests

3 participants