You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
🧐 Minor nitpick: Keymap class sounds very generic and behaves generic in that all of it's behaviour is specified through the options during construction. At the same time it now implements special treatment for ctrl-f. Seems counter intuitive that by adding a keymap to the editor that handles mod-s you also get special treatment for ctrl-f.
Maybe put the plugin into a separate class like BrowserSearch or so?
Mhhh, so this is merely about renaming a javascript class? 🧐
I'd suggest to either fix it straight away or close the issue 😉
I don't think there's much value in having issues about minor refactoring. Either it will happen along with other work anyway (and this issue will not be memorized by then) or it doesn't seem to be important enough 🤪
Agreed, I think Keymap still sounds sane as a naming, but we should move the Ctrl+S registration from the Editor.vue file to the actual plugin instead of using the options.
🧐 Minor nitpick:
Keymap
class sounds very generic and behaves generic in that all of it's behaviour is specified through the options during construction. At the same time it now implements special treatment forctrl-f
. Seems counter intuitive that by adding a keymap to the editor that handlesmod-s
you also get special treatment forctrl-f
.Maybe put the plugin into a separate class like
BrowserSearch
or so?Originally posted by @azul in #988 (comment)
The text was updated successfully, but these errors were encountered: