Missing close icon for modals

[mejo-]

The close icon of all our modals is missing since we upgraded to vue-material-design-icons 5.0.0.

• When opening a text document in a public folder share
• When opening the help modal from within a text document

After some debugging it seems like the icon slot of ActionButton, as used by the @nextcloud/vuejs Modal component, is empty for some reason.

Downgrading vue-material-design-icons to 4.12.0 brings back the Close icon, but I honestly don't understand what's happening there.

[juliusknorr]

We should check if this is still an issue now that @nextcloud/[email protected] is used where the upgrade of vie-material-design-icons was also included nextcloud-libraries/nextcloud-vue@44a4689

[mejo-]

I just tested shared folders when reviewing something else - and indeed the bug is still there on latest Nextcloud 24 with latest Text 😢

[szaimen]

I think the close button it is missing everywhere (whenever a modal is opened after the 5.0 upgrade)

[juliusknorr]

@vinicius73 Looked into that at nextcloud-libraries/nextcloud-vue#2529

Possible fix is waiting for a review in nextcloud-libraries/nextcloud-vue#2532

[mejo-]

This got fixed in @nextcloud/vue 5.1.1, which we're using since 9f8bfc9.