Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling the dark theme through Accessibility Settings hides the buttons #187

Closed
szaimen opened this issue Jul 21, 2019 · 13 comments
Closed
Labels
bug Something isn't working needs info

Comments

@szaimen
Copy link
Contributor

szaimen commented Jul 21, 2019

Describe the bug
Enabling the dark mode through Accessability Settings hides the buttons

To Reproduce
Steps to reproduce the behavior:

  1. Open the acessibility settings
  2. Enable dark theme
  3. Create a new text-file or open an existing one.
  4. The buttons are not visible.

Expected behavior
The buttons should be visible.

Client details:

  • OS: Android 9 (Pie)
  • Browser Chromium-based Browser (in Mobile View and in Desktop-View)
  • Version 75
  • Device: Samsung Galaxy S10E

Server Details:
I am running Nextcloud Snap 16.0.3 on Ubuntu 18.04 LTS and the latest version of the text-app.

@szaimen szaimen added the bug Something isn't working label Jul 21, 2019
@jancborchardt
Copy link
Member

Which buttons are you referring to? It all shows fine here:
Markdown dark theme

If you are referring to the header bar with title and the buttons for Close and Sidebar, they are currently fading out, set to be fixed in the next version, tracked in Viewer enhancements #82

@szaimen
Copy link
Contributor Author

szaimen commented Jul 23, 2019

No, that isn't working:
image
I have encircled the highlight of one of the buttons when dragging the mouse over it.
The icons are also not visible in mobile view.

I think the problem here is, that the icons don't get loaded correctly:
image

@jancborchardt
Copy link
Member

Handing over to @juliushaertl then.

@szaimen I guess a server log might be useful here, and the full URL of one of the icons – e.g. do you have /index.php/ in your path or not?

@juliusknorr
Copy link
Member

This is most likely an issue of the server in combination with the snap: nextcloud/server#13556

@szaimen
Copy link
Contributor Author

szaimen commented Jul 24, 2019

That is just one of many error messages in the server log:
{"reqId":"qBOfaFwWw1UH3TZT8r0i","level":3,"time":"2019-07-24T09:35:20+00:00","remoteAddr":"HIDDEN,"user":"HIDDEN","app":"lib","method":"GET","url":"\/index.php\/apps\/files\/","message":"ResourceLocator can not find a web root (root: \/var\/snap\/nextcloud\/14795\/nextcloud\/extra-apps\/text, file: index.php\/css\/text\/3acc-d459-icons.css?v=e5a3815d156a10062d0d3a1450cc937d, webRoot: , throw: true)","userAgent":"Mozilla\/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit\/537.36 (KHTML, like Gecko) Chrome\/75.0.3770.142 Safari\/537.36","version":"16.0.3.0"}

The URL of one of the missing icons looks like this:
image

@juliusknorr
Copy link
Member

Yes, look very much like the same error. Let's close this issue then, since there is nothing we can do on the text app side about this.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 24, 2019

Please reopen the Issue.
Maybe there is something you can do on the text app side about this:
After a few hours of trial and error I found out, that https://domain/extra-apps/text/img/italic.svg just works fine. If that also works with other installations e.g. from @jancborchardt (just open that link on your installation) you could bypass the Server error.

@juliusknorr
Copy link
Member

We cannot workaround that because the apps directory depends on the server configuration. You might have apps-extra where the text app is located but others might have it in the regular apps or an apps2 folder. The issue here is that the server cannot find the folder, since it is not inside of the nextcloud folder when using the snap.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 24, 2019

The issue here is that the server cannot find the folder, since it is not inside of the nextcloud folder when using the snap.

If that is really true, I wonder why the default path:
https://domain/index.php/svg/files/public also cannot be found but
https://domain/apps/files/img/recent.svg can?
And I am sure, that the files app is located in the normal way. (server/apps/files)

@juliusknorr
Copy link
Member

https://domain/index.php/svg/files/public is a dynamic endpoint (which is handled by the Nextcloud server code) that looks for the apps folder of the files app and returns the image. (this is what fails on your setup) https://domain/apps/files/img/recent.svg will be served by your webserver so Nextcloud is not involved there.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 24, 2019

Okay, thank you for sharing your knowledge!

@the-sane
Copy link

@szaimen You might want to comment about this over in the mentioned server issue, nextcloud/server#13556; maybe someone will finally take notice. Everyone who uses the snap or a nonstandard server configuration is affected by this and similar issues.

@szaimen
Copy link
Contributor Author

szaimen commented Jul 24, 2019

@juliushaertl Out of curiosity:
When I understand the icon-loading correctly, the dark and the white icons should get loaded from the same path, and the browser applies a color afterwards.
So what is the normale mode doing differently than the dark mode, so that the icons get loaded there correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs info
Projects
None yet
Development

No branches or pull requests

4 participants