Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archived Conversations 🗃️ #4333

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Archived Conversations 🗃️ #4333

wants to merge 3 commits into from

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 11, 2024 •
edited
Loading

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004
WIP
8eeca17 
Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Oct 11, 2024
@rapterjet2004 rapterjet2004 self-assigned this Oct 11, 2024
@rapterjet2004 rapterjet2004 changed the title Archived Conversations Archived Conversations 🗃️ Oct 11, 2024
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 15, 2024
@rapterjet2004
Ironed out the bugs
39305d7 
Signed-off-by: rapterjet2004 <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4333-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9498
Errors132132

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7979
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total109109

Lint increased!

@rapterjet2004 rapterjet2004 marked this pull request as ready for review October 16, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

At least 1 approving review is required to merge this pull request.

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "Archive conversation" feature
1 participant
@rapterjet2004