Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiline text insertion in chrome #1570

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Allow multiline text insertion in chrome #1570

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7866a7
Allow multiline text insertion in chrome
nickvergessen Feb 21, 2019
614bad4
Adjust vertical position of icons due to "inline-block" message in form
danxuliu Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions css/chatview.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,15 @@
width: calc(100% - 36px);
margin-left: 36px;
padding-right: 30px;
display: block;
/**
* The div needs to be inline-block, so Chrome/Chromium correctly insert
* div-ed multi-line-text with new lines.
* Otherwise they are just chained together on posting.
*
* See https://stackoverflow.com/a/24689420
* See https://github.com/nextcloud/spreed/issues/1561
*/
display: inline-block;
}

#chatView .newCommentForm .submit,
Expand All @@ -37,7 +45,7 @@
width: 44px;
height: 44px;

bottom: -4px;
bottom: -1px;
margin: 0;
}

Expand Down