Allow multiline text insertion in chrome #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The div needs to be inline-block, so Chrome/Chromium correctly insert div-ed multi-line-text with new lines. Otherwise they are just chained together on posting. See https://stackoverflow.com/a/24689420 See #1561 Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: chat 💬
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
reviewed
Feb 21, 2019
There was a problem hiding this comment.
I can not really review this, as I could not reproduce the original issue with Chromium 62 nor 68 neither in KDE nor IceWM; using inline-block or block makes no difference in my tests :-S
The only thing that changed with inline-block was the vertical position of icons in the new message form, which I fixed with an extra commit.
|
I run Chromium 71, you have to copy a div-ed text block, e.g. #1561 (comment) to see the issues |
|
/backport to stable15 |
nickvergessen
deleted the
bugfix/1561/multiline-insert-from-websites-in-chrome
branch
|
backport to stable15 in #1579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The div needs to be inline-block, so Chrome/Chromium correctly insert
div-ed multi-line-text with new lines.
Otherwise they are just chained together on posting.
See https://stackoverflow.com/a/24689420
Fix #1561