Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔣 Translate chat messages #9273

Closed
3 tasks done
nickvergessen opened this issue Apr 6, 2023 · 5 comments
Closed
3 tasks done

🔣 Translate chat messages #9273

nickvergessen opened this issue Apr 6, 2023 · 5 comments

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Apr 6, 2023


@nickvergessen nickvergessen added this to the 💙 Next Major (27) milestone Apr 6, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Apr 6, 2023
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Apr 6, 2023
@nickvergessen
Copy link
Member Author

@jancborchardt
Copy link
Member

A modal opens translating the message to the currently selected user language and allowing in a dropdown to translate to other languages

This sounds a bit complicated – I would rather go with how Instagram and Twitter do it and have a simple "Translate this message" action which only translates it to your language and places it below the original.
(Also talked about with @AndyScherzinger

We could of course have a modal to translate to other languages too, but that should be a separate second step. Otherwise it’s basically having full DeepL/Gtranslate app in there where you still need to manually do everything → instead of just simply clicking a button.

@jancborchardt jancborchardt moved this to 📐 Design phase in 🖍 Design team Apr 19, 2023
@AndyScherzinger
Copy link
Member

I think putting it in the 3dot menu on web or the long-press on mobile would be fine since showing it directly would mean we need to process all messages upfront to detect their original language to then decide when to show the translations action (as in show it when the language is not the one of the device). So putting it in the menu would be a good start.

@nickvergessen
Copy link
Member Author

Translate this message" action which only translates it to your language

So far the available translate app app only support a subset of en-de-es-zh-fr (https://github.com/nextcloud-releases/translate/releases/tag/v1.1.3)
For most users that will not cover their languages.

and places it below the original.

That would mean quite a lot of jumping up and down, and when the german translation is bad an english speaking german could not switch to english as a target to see if that is better.

instead of just simply clicking a button.

Well my suggestion would have been to try to detect the origin language and translate to the users language, but we need to handle when that does not exist, e.g. Dutch is not supported, but they might want to read English rather then french or something

@jancborchardt
Copy link
Member

@nickvergessen thanks for the explanation – ok then I’m good with a modal. Could be the same dialog as in Text.

@jancborchardt jancborchardt moved this from 📐 Design phase to 🏗️ At engineering in 🖍 Design team Apr 19, 2023
@nickvergessen nickvergessen moved this from 📄 To do (~10 entries) to 🆕 Next Major Changelog in 💬 Talk team May 4, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team May 12, 2023
@github-project-automation github-project-automation bot moved this from 🆕 Next Major Changelog to ☑️ Done in 💬 Talk team May 12, 2023
@nickvergessen nickvergessen moved this from ☑️ Done to 🆕 Next Major Changelog in 💬 Talk team May 12, 2023
@AndyScherzinger AndyScherzinger changed the title Translate chat messages 🔣 Translate chat messages May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

4 participants