Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur/modify background in video call #3151

Closed
jancborchardt opened this issue Mar 25, 2020 · 6 comments
Closed

Blur/modify background in video call #3151

jancborchardt opened this issue Mar 25, 2020 · 6 comments

Comments

@jancborchardt
Copy link
Member

This is not something for soon as it’s a bunch of work and there’ other things to be worked on first. But just for reference.


From https://news.ycombinator.com/item?id=22670896

I can’t begin to tell you how many times we have had people that need extra time to prepare for a meeting because of the background. As a manager, I have had lots of personal conversations with employees who legitimately stress out about getting the computer into a place with a good background.

@jancborchardt jancborchardt changed the title Background blur / modify background of video Blur/modify background in video call Mar 25, 2020
@nickvergessen nickvergessen added this to the 💔 Backlog milestone Mar 25, 2020
@PVince81
Copy link
Member

PVince81 commented Jul 7, 2021

Research technologies

The goal is mostly to find one that performs best and where the license is compatible.

  • tensorflow/body-pix

  • mediapipe

    • license ok? (Apache 2)
    • prototype
    • potential challenges with updates, because the library only comes in minified form and need some local changes
  • tflite ? (as pointed at by @LukasReschke internally)

    • license ok?
    • prototype ?
  • how big is the package to download, size of model ? should we load it on-demand after turning it on the first time ?

  • is it also possible to replace the blur with an image or video ?

Integration

  • feature flag (experimental, needs JS code copy-pasted to console to enable it, OR debug mode in config.php so that every developer sees it) @PVince81

  • implement plugin endpoint to allow registering video filter plugins to avoid the need to touch any of the internals (see Background blur effect demo #5918 for locations that need touching)

  • function to toggle blur background on and off: does this need stream swapping gymnastics to be able to get back to the original stream + performance ?

  • add button to toggle blur background on and off, possibly in the three dots menu with a keyboard shortcut "B"

  • remember last blur setting per conversation/token like we do for video/audio state

  • to test:

    • make sure that disabling/enabling video still keeps the blur
    • make sure the effect can survive disconnections/reconnections and the new "null stream" approach when idle
    • effect should not apply to screen shares, only videos
    • must continue working after video constraints are applied automatically
    • must work without HPB
    • must work with HPB
    • must work in all supported browsers

@nickvergessen FYI

@PVince81
Copy link
Member

PVince81 commented Jul 8, 2021

Next steps:

@PVince81
Copy link
Member

new PR here #6036

@PVince81
Copy link
Member

as discussed, a better wrapper around mediapipe ready to use: https://github.com/jpodwys/virtual-background

@nickvergessen
Copy link
Member

Done with #6322
Minor follow ups in #6345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants