Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display 'file-conversations' in talk if nobody actually sent a message in the share. #2382

Closed
marcoambrosini opened this issue Oct 31, 2019 · 3 comments
Closed

Do not display 'file-conversations' in talk if nobody actually sent a message in the share. #2382

marcoambrosini opened this issue Oct 31, 2019 · 3 comments
Labels
enhancement

Comments

@marcoambrosini
Copy link
Member

marcoambrosini commented Oct 31, 2019 •
edited
Loading

I think that if users just joins conversations automatically by opening the shared file without actually sending a message, we shouldn't display that conversations in the talk app.

The conversations list can get very long if you share files.

Screenshot_20191031_141743
@marcoambrosini
Copy link
Member Author

@nickvergessen @jancborchardt??

@nickvergessen
Copy link
Member

Fix is in #2347

@danxuliu danxuliu mentioned this issue Oct 31, 2019
Merged
@nickvergessen
Copy link
Member

Closing as per above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickvergessen @marcoambrosini