Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show description when listing open conversations #12209

Closed
SystemKeeper opened this issue Apr 25, 2024 · 0 comments · Fixed by #12243
Closed

Show description when listing open conversations #12209

SystemKeeper opened this issue Apr 25, 2024 · 0 comments · Fixed by #12243

Comments

@SystemKeeper
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature request

Which Nextcloud Version are you currently using: 29

Is your feature request related to a problem? Please describe.
When listing all open conversations on an instance it is sometimes hard to distinguish between conversations that sound similar.

Describe the solution you'd like
While the title and avatars are already visible when listing open conversations, descriptions are not. I would like to see the description as a subtitle in the open conversation list.

Describe alternatives you've considered
Use a more descriptive conversation title.

Additional context
I think this is handled at

if ($isSIPBridgeRequest
|| ($isListingBreakoutRooms && !$currentParticipant instanceof Participant)
|| ($room->getListable() !== Room::LISTABLE_NONE && !$currentParticipant instanceof Participant)
) {
return array_merge($roomData, [
'name' => $room->getName(),
'displayName' => $room->getDisplayName($isListingBreakoutRooms || $isSIPBridgeRequest || $this->userId === null ? '' : $this->userId, $isListingBreakoutRooms || $isSIPBridgeRequest),
'objectType' => $room->getObjectType(),
'objectId' => $room->getObjectId(),
'readOnly' => $room->getReadOnly(),
'hasCall' => $room->getActiveSince() instanceof \DateTimeInterface,
'lastActivity' => $lastActivity,
'callFlag' => $room->getCallFlag(),
'lobbyState' => $room->getLobbyState(),
'lobbyTimer' => $lobbyTimer,
'sipEnabled' => $room->getSIPEnabled(),
'listable' => $room->getListable(),
'breakoutRoomMode' => $room->getBreakoutRoomMode(),
'breakoutRoomStatus' => $room->getBreakoutRoomStatus(),
'callStartTime' => $room->getActiveSince() instanceof \DateTimeInterface ? $room->getActiveSince()->getTimestamp() : 0,
'callRecording' => $room->getCallRecording(),
]);
}
and could be easily extended to include the description.

@nickvergessen nickvergessen added this to the 💙 Next Major (30) milestone Apr 29, 2024
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 🆕 New to evalutate in 💬 Talk team Apr 29, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Apr 29, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to evalutate to ☑️ Done in 💬 Talk team May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging a pull request may close this issue.

2 participants