From 542dc2b3357d3e71b93ccd887ae19c564b9587e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Fri, 16 Feb 2018 12:00:07 +0100 Subject: [PATCH] Fix upload button visible on read-only folders MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The div that contains the elements related to the creation of new files, and thus the upload button, is always present in the DOM; it is hidden or shown based on the folder permissions by adding or removing the "hidden" CSS class. However, as the other CSS classes for the div are "actions" and "creatable" and a "display: flex" rule was defined for ".actions.creatable" below the "display: none" rule for ".actions.hidden" the last one took precedence and the div ended being always visible, even if the "hidden" CSS class was set. Now the rules for the ".actions.hidden" selector are defined below the rules for the ".actions.creatable" selector and thus the "display: none" rule is applied as expected. Signed-off-by: Daniel Calviño Sánchez --- apps/files/css/files.scss | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/files/css/files.scss b/apps/files/css/files.scss index b29ce9ea9507d..1be58cff5a105 100644 --- a/apps/files/css/files.scss +++ b/apps/files/css/files.scss @@ -16,7 +16,6 @@ .actions .button a:active { color: #333; } -.actions.hidden { display: none; } .actions.creatable { position: relative; @@ -27,6 +26,10 @@ } } +.actions.hidden { + display: none; +} + #trash { margin-right: 8px; float: right;