Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Vite for bundling and allow to share modules #43553

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Migrate to Vite for bundling and allow to share modules #43553

wants to merge 12 commits into from
+7,609 −26,268

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 13, 2024

Summary

TBD

TODO

  • Testing

Checklist

@susnux susnux mentioned this pull request Feb 13, 2024
Merged
4 tasks
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
@juliusknorr juliusknorr mentioned this pull request Mar 26, 2024
Open
3 tasks
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@susnux susnux force-pushed the chore/migrate-vite branch 5 times, most recently from 4ff8492 to 3cc62a4 Compare May 3, 2024 14:38
@susnux

This comment was marked as resolved.

Sign in to view
@susnux susnux mentioned this pull request May 3, 2024
Merged
4 tasks
@susnux susnux force-pushed the chore/migrate-vite branch 2 times, most recently from e1e317b to 350666e Compare June 8, 2024 13:17
@susnux
feat!: Migrate from webpack to vite for bundling
a68e4a5 
Also use patched `davclient.js` package

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: Remove now unneeded webpack nounce configuration
78240db 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix!: Split legacy dependency modules into own chunk
f23ebda 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: Set up module-preload for Vite
ca12c7f 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
feat: Allow sharing JavaScript modules across apps and core
24b493e 
Initially `vue` and `@nextcloud/vue` are shared by server core.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(settings): Adjust invalid import
e71a45a 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix: Precompile systemtags handlebars templates
7d2f511 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(UnifiedSearch): Fix imports to work without implicit window as `g…
9806dec 
…lobalThis`

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(dashboard): Adjust code to work without implicit window as `globa…
df712c5 
…lThis`

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented Jun 17, 2024

TODO: Migrate the SPDX license plugin

@susnux
chore: Compile assets
b8e9494 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv will be requested when the pull request is marked ready for review skjnldsv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @skjnldsv