Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to post multi line comments anymore #942

Closed
nickvergessen opened this issue Aug 18, 2016 · 5 comments
Closed

Not possible to post multi line comments anymore #942

nickvergessen opened this issue Aug 18, 2016 · 5 comments
Labels
bug design Design, UI, UX, etc.

Comments

@nickvergessen
Copy link
Member

Since #714
Neither Enter nor Shift + Enter work.
Would be nice to get that back @jancborchardt

The design changes look really good btw.

@rullzer
Copy link
Member

rullzer commented Aug 19, 2016

Yep I noted that in the issue as well.
Maybe we could just catch CTRL+enter and then convert to a textarea?

Altough that might be great cross browser fun.

@jancborchardt
Copy link
Member

It was intentionally changed to single-line comments because it’s intended to be a quick comment function, not writing a whole bunch of text.

@nickvergessen
Copy link
Member Author

This is odd, apps that use comments for "longer" context now have to use a different style then the server feature?

@jancborchardt
Copy link
Member

Right, good point. If you’d like to change it then a few things would be good:

  • don’t make it too high, 3 rows maximum
  • use https://github.com/jackmoore/autosize so the input field automatically resizes, and remove the resize handle (like we do in the mail app)
  • have the icon-confirm button float in the bottom right of the textarea like it does now in the input field
  • make Ctrl-Enter submit the comment

Does that sound good?

@nickvergessen
Copy link
Member Author

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Design, UI, UX, etc.
Projects
None yet
Development

No branches or pull requests

3 participants